Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FindGroups method to UserProvider API #94

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

ishank011
Copy link
Contributor

No description provided.

@ishank011 ishank011 requested a review from labkode as a code owner October 5, 2020 09:28
prototool.yaml Outdated
@@ -30,5 +33,5 @@ generate:
plugins:
- name : go
type: go
flags: plugins=grpc
flags: plugins=grpc,paths=source_relative
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build https://cloud.drone.io/cs3org/cs3apis/323/1/2 is failing with warnings that the go-package name should be the full path, but prototool doesn't support that. Tried a couple of fixes from here uber/prototool#549 but those aren't working.

I can't seem to figure out where the dependencies got updated. This commit cs3org/cs3apis-build#1 was merged today but that doesn't update anything. Maybe there's an implicit dependency in the dockerfile https://github.com/cs3org/cs3apis-build/blob/master/Dockerfile which got updated when a new image was published.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example contains:
flags: plugins=grpc # didn't appear to need 'paths=source_relative', but outputting to a different location,
@ishank011 can you try without the paths=source_relative option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried that as well

@labkode labkode merged commit a6cf2aa into cs3org:master Oct 6, 2020
@ishank011 ishank011 deleted the find-groups branch October 7, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants