Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add list and add ep for ocm core shares #66

Closed
wants to merge 2 commits into from
Closed

[WIP] Add list and add ep for ocm core shares #66

wants to merge 2 commits into from

Conversation

LovisaLugnegard
Copy link
Contributor

No description provided.

@LovisaLugnegard LovisaLugnegard changed the title Add list and add ep for ocm core shares WIP Add list and add ep for ocm core shares Apr 20, 2020
@ishank011
Copy link
Contributor

These need to be compliant with the definitions at https://rawgit.com/GEANT/OCM-API/v1/docs.html, like the CreateOCMCoreShare method.

@labkode
Copy link
Member

labkode commented Apr 21, 2020

Hi, I realized that we don't need to add these methods right now as we won't probably need them. This PR, which is the latest state of the OCM implementation by some vendors removes these two endpoints, only relies on the createShare:
cs3org/OCM-API#37

So we keep this PR in our back in case in the future we'll need to add them.

@labkode labkode changed the title WIP Add list and add ep for ocm core shares [WIP] Add list and add ep for ocm core shares Apr 21, 2020
@LovisaLugnegard
Copy link
Contributor Author

I'll close this PR then, doesn't spark joy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode Awaiting requested review from labkode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LovisaLugnegard @ishank011 @labkode