Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: added ListExistingReceivedShares to gateway API #228

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

glpatcern
Copy link
Member

@glpatcern glpatcern commented Mar 22, 2024

This API is to be consumed by:

  • the OCS (HTTP) service
  • the LibreGraph API
  • (in the future) the Jupyterlab integration

The idea is to incorporate in the gateway the current logic implemented (and duplicated) in other layers, where after ListReceivedShares one has to Stat each of them to validate it exists and get all necessary metadata to send the response (in the form of LibreGraph or OCS). This logic is to be implemented by the Gateway instead, which can incorporate any caching logic as needed.

@glpatcern
Copy link
Member Author

glpatcern commented Apr 3, 2024

@labkode @diocas : having discussed with @gmgigi96 I think it makes sense to have this before we go live with the Spaces implementation, as the LibreGraph API does not cache the list of shares (that is currently implemented by the OCS layer only). It shouldn't be a big development but rather a code refactoring, where we move the code within the Gateway - the LibreGraph part is very simple, the OCS part a bit less but provided we agree on this API, I can look into it (I may need some help on the OCS part from @labkode).

@labkode
Copy link
Member

labkode commented Apr 3, 2024

@glpatcern much better now! I don't understand the logic of moving it to the Spaces part unfortunately, the idea is to have an implementation in the gateway and adapt the upper clients, the caching can then be done at the gateway level so there is no need to modify OCS/Libregraph (just removing caching code).

@glpatcern
Copy link
Member Author

I don't understand the logic of moving it to the Spaces part

Bad wording, I rephrased my comment. Indeed the whole idea is to have the gateway encapsulate all the business logic and caching. This goes also along the lines of what we discussed with @butonic at CS3 a few weeks ago: OCS and LibreGraph would be a minimal translation layer (so code has to be removed) in front of the gateway.

@labkode labkode self-requested a review April 3, 2024 14:38
@labkode labkode merged commit 0f3d9ed into cs3org:main Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants