Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further clarified scope of lock_id #227

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Further clarified scope of lock_id #227

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4daab2
Further clarified scope of lock_id in storage-related requests that d…
glpatcern Mar 5, 2024
c0270bb
minor fix
glpatcern Mar 22, 2024
63600a6
minor fix
glpatcern Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions cs3/storage/provider/v1beta1/provider_api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,9 @@ message AddGrantRequest {
Grant grant = 3;
// OPTIONAL.
// A lock_id: should the reference be locked, the stored
// lock_id MUST be equal to the given value.
// lock_id SHOULD be equal to the given value. However,
// storage implementations MAY allow for setting grants
// even if the lock does not match.
string lock_id = 4;
}

Expand All @@ -230,7 +232,9 @@ message DenyGrantRequest {
Grantee grantee = 3;
// OPTIONAL.
// A lock_id: should the reference be locked, the stored
// lock_id MUST be equal to the given value.
// lock_id SHOULD be equal to the given value. However,
// storage implementations MAY allow for setting grants
// even if the lock does not match.
string lock_id = 4;
}

Expand Down Expand Up @@ -786,7 +790,9 @@ message RemoveGrantRequest {
Grant grant = 3;
// OPTIONAL.
// A lock_id: should the reference be locked, the stored
// lock_id MUST be equal to the given value.
// lock_id SHOULD be equal to the given value. However,
// storage implementations MAY allow for unsetting grants
// even if the lock does not match.
string lock_id = 4;
}

Expand Down Expand Up @@ -840,7 +846,9 @@ message UpdateGrantRequest {
Grant grant = 3;
// OPTIONAL.
// A lock_id: should the reference be locked, the stored
// lock_id MUST be equal to the given value.
// lock_id SHOULD be equal to the given value. However,
// storage implementations MAY allow for updating grants
// even if the lock does not match.
string lock_id = 4;
}

Expand Down Expand Up @@ -908,7 +916,9 @@ message SetArbitraryMetadataRequest {
ArbitraryMetadata arbitrary_metadata = 3;
// OPTIONAL.
// A lock_id: should the reference be locked, the stored
// lock_id MUST be equal to the given value.
// lock_id SHOULD be equal to the given value. However,
// storage implementations MAY allow for setting attributes
// even if the lock does not match.
string lock_id = 4;
}

Expand All @@ -933,7 +943,9 @@ message UnsetArbitraryMetadataRequest {
repeated string arbitrary_metadata_keys = 3;
// OPTIONAL.
// A lock_id: should the reference be locked, the stored
// lock_id MUST be equal to the given value.
// lock_id SHOULD be equal to the given value. However,
// storage implementations MAY allow for unsetting attributes
// even if the lock does not match.
string lock_id = 4;
}

Expand Down