-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a URL object in OpenInAppResponse #139
Conversation
map<string, string> form_parameters = 3; | ||
// OPTIONAL. | ||
// The headers to be added to the request. | ||
map<string, string> headers = 4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read up on forms a little bit. The GET
method on a form submit will add the form fields to the query parameters in the URL whereas the POST
method will put them in the body (https://developer.mozilla.org/en-US/docs/Learn/Forms/Sending_and_retrieving_form_data).
But in neither case there is an explicit option to set Headers. How would it be used then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible to pass headers to iframes, albeit not in a straightforward manner https://stackoverflow.com/a/60571237. The apps which we're considering don't need any to be set but it would be a good functionality to have IMO.
…ct in ListSupportedMimeTypes
I've added a couple of fields to |
As discussed, I'm merging this given that we tested the whole chain and we are ready to merge cs3org/reva#1968 as well. |
This PR has a breaking change. Previously, we returned a string as the URL as part of
OpenInAppResponse
. Now, we return a complete URL object which also specifies the method to be used to call the URL, the headers, and the form parameters to be specified. Related cs3org/reva#1923cc @wkloucek