-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write only management API for User and Group resources #119
Conversation
@refs can you run |
thanks for the review! good catch with the offset attribute ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would more descriptive method names be helpful? Eg, CreateGroup
, AddUserToGroup
?
Oh, I was thinking the same, then did a little read on Google's guidelines and left the namespace be more explicit. BUT apparently I did not have a look at the examples which explicitly append the resource name to the method haha, let me amend the changes |
@ishank011 just renamed the methods to stick to these guidelines 👍 |
What?
Essentially a write-only management API for User and Group resources. The CS3 API already provides the means for retrieving information for resources such as users and groups but it does not dictate how such resources are created. These minimal changes would add a different write layer to an administration API that would deal with destructive actions. Ultimately admin actions MUST only be taken by users with the role of administrator.
Adding roles will not be yet accounted for in this patch, and implementations should instead rely on their own logic to deal with roles, but a PR will follow up that would add roles to the CS3 API.
Design Choices