Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise any other protocol in the discovery endpoint #93

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

glpatcern
Copy link
Member

@glpatcern glpatcern commented Aug 22, 2024

This is a proposal in order to standardize how to show additional protocols in the discovery endpoint.

I'm not sure it can be espressed in OpenAPI 2.0. One more reason to convert to OpenAPI 3.0?

Edit: I fixed the PR (still with OpenAPI 2.0) so to allow to specify <any name> : "<url>", similar to how Nextcloud advertises their talk protocol:

      "protocols": {
        "talk-v1": "/ocs/v2.php/apps/spreed/api/"
      }

And the included example is deliberately inspired to the above.

@ArtificialOwl this makes Nextcloud's discovery fully standard ;-)

@glpatcern glpatcern marked this pull request as draft August 22, 2024 07:30
@glpatcern glpatcern mentioned this pull request Aug 22, 2024
@MahdiBaghbani

This comment was marked as resolved.

@glpatcern
Copy link
Member Author

For reference, this is the discovery endpoint of Nextcloud:

https://cloud.nextcloud.com/ocm-provider

@MahdiBaghbani

This comment was marked as resolved.

@glpatcern glpatcern force-pushed the disco-protocols branch 2 times, most recently from 04153d8 to b9062b2 Compare August 29, 2024 09:29
@glpatcern glpatcern marked this pull request as ready for review August 29, 2024 09:31
@glpatcern glpatcern force-pushed the disco-protocols branch 2 times, most recently from 8964729 to 80f4037 Compare August 29, 2024 09:38
@michielbdejong michielbdejong merged commit f07bb07 into cs3org:develop Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants