Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft text to rewrite this API doc to more of a protocol spec #61

Merged
merged 9 commits into from
May 9, 2023

Conversation

michielbdejong
Copy link
Contributor

No description provided.

@michielbdejong michielbdejong marked this pull request as draft March 5, 2023 08:50
@michielbdejong
Copy link
Contributor Author

I was thinking this document could be more valuable if we add some more text around the different steps sender and receiver go through.

By using "MAY" instead of "SHOULD" in the right places, I think this is possible without adding more requirements or bringing things into scope that are currently out of scope.

For instance, we can document /ocm-provider and describe how it is used in practice in some real-world interactions (even in an interoperable way across implementations!), but without making it a requirement. For instance when sharing only from and to the ScienceMesh, this endpoint is not needed.

Another example are the notificationType strings that are used interoperably across some (but not all) implementations in practice; we can at least describe the prevalent notificationType strings as things a server "MAY" support, so we don't end up with an eco-system where the same notification type is identified with more than one string.

Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Michiel, I think we should also resume this in view of v1.1. I have contributed the invite workflow and amended a couple of things also given that the discovery endpoint is officially in the spec. What do you think?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@michielbdejong michielbdejong marked this pull request as ready for review April 28, 2023 08:33
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@glpatcern
Copy link
Member

I have incorporated the invite description so it's easier to read through. For the rest, I leave it to you to have a look / improve.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to move on with all this, as discussed we can always improve and the added text already documents several undocumented aspects. I will also build on top of this to document the webdav access in OCM v1.0, as discussed in #70.

@glpatcern glpatcern merged commit 28a5cd4 into develop May 9, 2023
@glpatcern glpatcern deleted the interop branch May 15, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants