-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFA: Change from permission to a new concept requirement
#132
Conversation
A requirement is a restriction on a resource, an anti permission if you will. Currently two types exist, `mfa-enforced` and `none`. Requirements are required to be set on a resource, so that an implementor can check requirements without having to check if the attribute is set in the request beforehand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just a couple of comments, as well as a more general question: I'd introduce a signed
requirement as well, as mentioned yesterday. After all it does not cost much - requirements are optional - but given that signatures are ALSO optional for backwards compatibility, there's a way to enforce them if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mickenordin can you have a look at the comments and merge this? |
Co-authored-by: Michiel de Jong <michiel@unhosted.org>
I would prefer if we add the |
All right, and yes I believe it must - as for the |
A requirement is a restriction on a resource, an anti permission if you
will. Currently two types exist,
mfa-enforced
andnone
.Requirements are required to be set on a resource, so that an
implementor can check requirements without having to check if the
attribute is set in the request beforehand.
Please note that the token endpoint removed in the first commit is a duplicate, so it is still in the spec :)