[wip] solc parser rewrite #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 7 alerts when merging 201d373 into 290a99f - view on LGTM.com new alerts:
|
|
This pull request introduces 7 alerts when merging 7e16023 into 290a99f - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 9555104 into 290a99f - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging f518488 into 290a99f - view on LGTM.com new alerts:
|
samczsun
force-pushed
the
feature/parser-rewrite
branch
from
f518488 to
f6ced52
Compare
|
This pull request introduces 2 alerts when merging f6ced52 into 4812e33 - view on LGTM.com new alerts:
|
|
I am closing this PR. While this was great progress, the codebase has evolved too much for this PR to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the codebase is littered with
is_compact_astand it's hard to work with magic dictionaries everywhere. this PR introduces a new parsing step which translates solc ast json into a plain python object and handles any inconsistencies between different solc versions.creating the pr now so I can have the ci run some tests
todo: