Enable running slither as pre-commit hook #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
elopez
reviewed
Aug 13, 2024
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
|
the ci/test failures seem unrelated... anything else I can do for this PR from my side, like explaining things a bit more / add a test workflow? |
|
@dbast Thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit became pretty popular as framework to combine linters / code-formatters via hooks across different languages. It can be enabled as actual git hook or just used by running
pre-commit run -a. pre-commit does its own dependency management and uses virtual envs for the Python hooks (= no need to put linters requirements*.txt files for Python projects)This adds a
.pre-commit-hooks.yaml, which allows other projects to run slither via pre-commit.Tested it in my fork with custom test tag, see dbast/sol-press#10