improve name resolution of type aliases #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xalpharush
changed the title
0xalpharush
changed the title
|
@smonicas will you open an issue with a test case for what isn't working with the fully qualified name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1809
This fix the specific example in the issue however it doesn't work if you use a type alias from another contract e.g.
DeleteTest.Z.wrap(4).BREAKING CHANGE: Renamed
user_defined_typestotype_aliasesso it's less confusing with what we call UserDefinedType.Added type aliased at the Contract level so now at the file scope there are only top level aliasing and fully qualified contract aliasing like
C.myAlias.