Abstract contract property #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsamuels453
requested review from
montyly,
0xalpharush and
smonicas
as code owners
|
|
Closed
montyly
requested changes
Mar 6, 2023
|
It'd be nice to have test cases to known when this will return |
|
Note: this is currently failing because of #1741 |
0xalpharush
force-pushed
the
abstract-contract
branch
from
5c0fe44 to
5a37d30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an "is_abstract" property to the contract class. Without this class property, detectors can only check for abstractness by verifying all of the functions have implementations.