Fix __eq__() in ArrayType and UserDefinedType
#1506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves false negatives in the `DifferentVariableContractProxy` and `DifferentVariableContractNewContract` upgradeability checks in [variables_order.py](https://github.com/crytic/slither/blob/master/slither/tools/upgradeability/checks/variables_order.py) when comparing two arrays of contract types. E.g. when comparing `CToken[] public allMarkets` against itself in two versions of an inherited storage contract, as well as `mapping(address => CToken[]) public accountAssets`, the `order-vars-contracts` upgradeability check was telling me these two variables didn't match when they clearly did.
Workaround due to `Contract.__eq__()` not being implemented in master branch, except when comparing Contract object to string. Would be better if `Contract.__eq__()` were fully implemented (see PR crytic#895).
webthethird
changed the title
__eq__() in ArrayType__eq__() in ArrayType and UserDefinedType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves false negatives in the
DifferentVariableContractProxyandDifferentVariableContractNewContractupgradeability checks in variables_order.py when comparing two arrays of contract types.E.g. when comparing
CToken[] public allMarketsagainst itself in two versions of an inherited storage contract, as well asmapping(address => CToken[]) public accountAssets, theorder-vars-contractsupgradeability check was telling me these two variables didn't match when they clearly did.Note: to completely resolve other related false negatives, i.e., resulting from direct comparison of two contracts or structures, at least some of the
__eq__()method implementations which I suggested in PR #895 should also be merged in.