Detector for encodeWithSelector wrong argument count/ mismatched types #1292
+321
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging ecd8adb into d0a4f55 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 7ce0a71 into d0a4f55 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 5fbbef5 into d0a4f55 - view on LGTM.com new alerts:
|
0xalpharush
suggested changes
Jul 21, 2022
slither/detectors/compiler_bugs/wrong_selector_with_selector.py
Outdated
Show resolved
Hide resolved
slither/detectors/compiler_bugs/wrong_selector_with_selector.py
Outdated
Show resolved
Hide resolved
slither/detectors/compiler_bugs/wrong_selector_with_selector.py
Outdated
Show resolved
Hide resolved
slither/detectors/compiler_bugs/wrong_selector_with_selector.py
Outdated
Show resolved
Hide resolved
slither/detectors/compiler_bugs/wrong_selector_with_selector.py
Outdated
Show resolved
Hide resolved
slither/detectors/compiler_bugs/wrong_selector_with_selector.py
Outdated
Show resolved
Hide resolved
slither/detectors/compiler_bugs/wrong_selector_with_selector.py
Outdated
Show resolved
Hide resolved
slither/detectors/compiler_bugs/wrong_selector_with_selector.py
Outdated
Show resolved
Hide resolved
Co-authored-by: alpharush <0xalpharush@protonmail.com>
Co-authored-by: alpharush <0xalpharush@protonmail.com>
Co-authored-by: alpharush <0xalpharush@protonmail.com>
Co-authored-by: alpharush <0xalpharush@protonmail.com>
|
This pull request introduces 1 alert when merging 15d79b4 into d0a4f55 - view on LGTM.com new alerts:
|
0xalpharush
reviewed
Jun 22, 2023
slither/detectors/compiler_bugs/wrong_selector_with_selector.py
Outdated
Show resolved
Hide resolved
0xalpharush
reviewed
Jun 22, 2023
slither/detectors/compiler_bugs/wrong_selector_with_selector.py
Outdated
Show resolved
Hide resolved
0xalpharush
reviewed
Jun 22, 2023
slither/detectors/compiler_bugs/wrong_selector_with_selector.py
Outdated
Show resolved
Hide resolved
0xalpharush
reviewed
Jun 22, 2023
slither/detectors/compiler_bugs/wrong_selector_with_selector.py
Outdated
Show resolved
Hide resolved
|
Can we add a test case that uses an array type as an argument please? |
0xalpharush
changed the title
0xalpharush
reviewed
Jun 22, 2023
...e/detectors/snapshots/detectors__detector_WriteAfterWrite_0_8_0_write_after_write_sol__0.txt
Outdated
Show resolved
Hide resolved
0xalpharush
suggested changes
Sep 22, 2023
| else: | ||
| return result | ||
|
|
||
| _, _, argument_types = func_ids[selector.value] |
There was a problem hiding this comment.
This causes an error on 0x9078f5996746f134f761b93939b0fd595f68845e. We should return early if we cannot determine which function the selector map backs to until we integrate a selector db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Solc Compiler does not help checking that the arguments used in when building the transaction calldata with encodeWhitSelector matches the target function. This detector look for miss-matching encodeWithSelector arguments and target function arguments.