Fix IR conversion when an Event selector is accessed

crytic · Oct 11, 2024 · 4b91acd · 4b91acd
1 parent 9e89bbb
commit 4b91acd
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 3 deletions.
diff --git a/slither/slithir/convert.py b/slither/slithir/convert.py
@@ -81,7 +81,7 @@
 from slither.slithir.tmp_operations.tmp_new_structure import TmpNewStructure
 from slither.slithir.variables import Constant, ReferenceVariable, TemporaryVariable
 from slither.slithir.variables import TupleVariable
-from slither.utils.function import get_function_id
+from slither.utils.function import get_function_id, get_event_id
 from slither.utils.type import export_nested_types_from_variable
 from slither.utils.using_for import USING_FOR
 from slither.visitors.slithir.expression_to_slithir import ExpressionToSlithIR
@@ -793,8 +793,18 @@ def propagate_types(ir: Operation, node: "Node"):  # pylint: disable=too-many-lo
                     assignment.set_node(ir.node)
                     assignment.lvalue.set_type(ElementaryType("bytes4"))
                     return assignment
-                if ir.variable_right == "selector" and isinstance(
-                    ir.variable_left.type, (Function)
+                if ir.variable_right == "selector" and isinstance(ir.variable_left, (Event)):
+                    assignment = Assignment(
+                        ir.lvalue,
+                        Constant(str(get_event_id(ir.variable_left.full_name))),
+                        ElementaryType("bytes32"),
+                    )
+                    assignment.set_expression(ir.expression)
+                    assignment.set_node(ir.node)
+                    assignment.lvalue.set_type(ElementaryType("bytes32"))
+                    return assignment
+                if ir.variable_right == "selector" and (
+                    isinstance(ir.variable_left.type, (Function))
                 ):
                     assignment = Assignment(
                         ir.lvalue,

diff --git a/slither/utils/function.py b/slither/utils/function.py
@@ -12,3 +12,16 @@ def get_function_id(sig: str) -> int:
     digest = keccak.new(digest_bits=256)
     digest.update(sig.encode("utf-8"))
     return int("0x" + digest.hexdigest()[:8], 16)
+
+
+def get_event_id(sig: str) -> int:
+    """'
+        Return the event id of the given signature
+    Args:
+        sig (str)
+    Return:
+        (int)
+    """
+    digest = keccak.new(digest_bits=256)
+    digest.update(sig.encode("utf-8"))
+    return int("0x" + digest.hexdigest(), 16)