fix: check that receipt is non-nil in OnTxEnd hook
#457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishnaik
changed the title
0xalpharush
reviewed
Aug 27, 2024
| // We avoid storing the trace for this transaction. An error should realistically only occur if we hit a block gas | ||
| // limit error. In this case, the transaction will be retried in the next block and we can retrieve the trace at | ||
| // that time. | ||
| if err != nil || receipt == nil { |
There was a problem hiding this comment.
Suggested change
| if err != nil || receipt == nil { | |
| if receipt == nil { |
I don't think we need to check both but I will merge as is
0xalpharush
approved these changes
Aug 27, 2024
0xalpharush
changed the title
OnTxEnd hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to store the execution trace without checking the error or whether the receipt was nil in the
OnTxEndhook. This seemed fine initially but it is possible that if the block's gas limit is reached, the receipt will be nil and error non-nil because the txn could not be fit into the block.This PR changes the hook such that the trace is not stored if the receipt is nil or error is non-nil. The reasoning for this is that medusa will retry the failing txn in the next block and at that time we should be able to get the trace.