Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for profiling; improve default.nix #704

Merged
merged 6 commits into from
Jan 11, 2022
Merged

Conversation

samalws
Copy link
Contributor

@samalws samalws commented Dec 21, 2021

This PR adds a section to README.md explaining how to run a profiling build and how to use profiling.

This PR also improves default.nix, allowing for profiling, fixing shellHook, and allowing you to toggle tests.

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@elopez elopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sam! This looks good overall! 👍

On a more general note, I'm wondering if we should have a folder to put scripts in, we now have some in .github/scripts for e.g. installing dependencies, that could certainly live somewhere more discoverable.

@samalws
Copy link
Contributor Author

samalws commented Dec 21, 2021

@elopez I've amended the commit with all your suggestions, thanks

@samalws samalws changed the title Script to autogenerate profiles Script to autogenerate profiles; improve default.nix Dec 27, 2021
Copy link
Member

@arcz arcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this script under scripts/autogen-profiles.sh instead of .github/scripts/autogen-profiles.sh? I think we could also name it profile-examples.sh.

@samalws samalws changed the title Script to autogenerate profiles; improve default.nix Instructions for profiling; improve default.nix Jan 5, 2022
@arcz arcz merged commit e2d6c81 into crytic:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants