-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions for profiling; improve default.nix #704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sam! This looks good overall! 👍
On a more general note, I'm wondering if we should have a folder to put scripts in, we now have some in .github/scripts
for e.g. installing dependencies, that could certainly live somewhere more discoverable.
@elopez I've amended the commit with all your suggestions, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put this script under scripts/autogen-profiles.sh
instead of .github/scripts/autogen-profiles.sh
? I think we could also name it profile-examples.sh
.
This PR adds a section to README.md explaining how to run a profiling build and how to use profiling.
This PR also improves default.nix, allowing for profiling, fixing shellHook, and allowing you to toggle tests.