Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show gas per second in the UI #1279

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Show gas per second in the UI #1279

merged 1 commit into from
Jun 26, 2024

Conversation

samalws-tob
Copy link
Collaborator

@samalws-tob samalws-tob commented Jun 26, 2024

This will help for determining performance. We keep track of gas consumption after each transaction call, rather than after each instruction: hevm handles the bookkeeping at the instruction level. Should have a very minimal effect on performance, since hevm already keeps track of gas consumption strictly: burned :: !(Gas t) (hevm/src/EVM/Types.hs:620).

I'm unsure whether we should be keeping track of totalGas as an Int or as hevm's native Gas type. One way or another we need to cast to a different type to display it onscreen. In any case this choice is only a minor issue

@arcz arcz merged commit 882c699 into master Jun 26, 2024
18 checks passed
@arcz arcz deleted the gasPerSecond branch June 26, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants