Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hevm to 0.51.3 #1090

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Update hevm to 0.51.3 #1090

merged 1 commit into from
Jul 17, 2023

Conversation

arcz
Copy link
Member

@arcz arcz commented Jul 11, 2023

Closes #1085 and #1049.

@arcz arcz requested a review from ggrieco-tob as a code owner July 11, 2023 08:31
@arcz arcz force-pushed the hevm-0.51.2 branch 2 times, most recently from ba9b727 to 5b2ab2b Compare July 11, 2023 09:46
@@ -116,7 +116,7 @@ canShrinkTx Tx { call, gasprice = 0, value = 0, delay = (0, 0) } =
canShrinkTx _ = True

removeCallTx :: Tx -> Tx
removeCallTx t = Tx NoCall 0 t.src 0 0 0 t.delay
removeCallTx t = Tx NoCall t.src t.dst 0 0 0 t.delay
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this was changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t.src was in the wrong place and having 0 in the src caused a crash in tx generation which was previously not triggered as there was something deployed on the address 0. I think this was changed in hevm and now there is nothing deployed on 0.

@arcz arcz marked this pull request as draft July 11, 2023 19:22
@rappie
Copy link

rappie commented Jul 11, 2023

Does this include the new cheatcodes for diffusc?

@arcz
Copy link
Member Author

arcz commented Jul 12, 2023

Not yet, unfortunately. It is still in progress ethereum/hevm#259.

@arcz arcz marked this pull request as ready for review July 14, 2023 15:55
@arcz arcz changed the title Update hevm to 0.51.2 Update hevm to 0.51.3 Jul 14, 2023
@arcz arcz merged commit f4dfed2 into master Jul 17, 2023
15 checks passed
@arcz arcz deleted the hevm-0.51.2 branch July 17, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print a warning if 0.8.20 is used
3 participants