Fix faulty corpus transaction detection (#1184)

* Fix faulty corpus transaction detection * Don't execute NoCalls
crytic · Feb 2, 2024 · f641d1a · f641d1a
1 parent 1d0c937
commit f641d1a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/lib/Echidna/Campaign.hs b/lib/Echidna/Campaign.hs
@@ -68,7 +68,9 @@ replayCorpus
   -> m ()
 replayCorpus vm txSeqs =
   forM_ (zip [1..] txSeqs) $ \(i, (file, txSeq)) -> do
-    let maybeFaultyTx = List.find (\tx -> LitAddr tx.dst `notElem` Map.keys vm.env.contracts) txSeq
+    let maybeFaultyTx =
+          List.find (\tx -> LitAddr tx.dst `notElem` Map.keys vm.env.contracts) $
+            List.filter (\case Tx { call = NoCall } -> False; _ -> True) txSeq
     case maybeFaultyTx of
       Nothing -> do
         _ <- callseq vm txSeq

diff --git a/lib/Echidna/Exec.hs b/lib/Echidna/Exec.hs
@@ -87,11 +87,14 @@ execTxWith executeTx tx = do
     #traces .= emptyEvents
     vmBeforeTx <- get
     setupTx tx
-    gasLeftBeforeTx <- gets (.state.gas)
-    vmResult <- runFully
-    gasLeftAfterTx <- gets (.state.gas)
-    handleErrorsAndConstruction vmResult vmBeforeTx
-    pure (vmResult, gasLeftBeforeTx - gasLeftAfterTx)
+    case tx.call of
+      NoCall -> pure (VMSuccess (ConcreteBuf ""), 0)
+      _ -> do
+        gasLeftBeforeTx <- gets (.state.gas)
+        vmResult <- runFully
+        gasLeftAfterTx <- gets (.state.gas)
+        handleErrorsAndConstruction vmResult vmBeforeTx
+        pure (vmResult, gasLeftBeforeTx - gasLeftAfterTx)
   where
   runFully = do
     config <- asks (.cfg)

diff --git a/lib/Echidna/Transaction.hs b/lib/Echidna/Transaction.hs
@@ -161,7 +161,6 @@ setupTx tx@Tx{call = NoCall} = fromEVM $ do
     { state = vm.state
     , block = advanceBlock vm.block tx.delay
     }
-  modify' $ execState $ loadContract (LitAddr tx.dst)
 
 setupTx tx@Tx{call} = fromEVM $ do
   resetState