Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error message details only when needed #46

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Show error message details only when needed #46

merged 2 commits into from
Dec 26, 2023

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Dec 26, 2023

No description provided.

jwoertink
jwoertink approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok. Yeah, this makes sense since if the details.size is one, the "raw" message will be the exact same as the title.

@jwoertink jwoertink merged commit e09f8d8 into crystal-loot:master Dec 26, 2023
4 checks passed
@Sija
Copy link
Contributor Author

Sija commented Dec 26, 2023

Could this be released as a v0.4.1?

@jwoertink
Copy link
Contributor

done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sija @jwoertink