examples: fix (2020-04) #9203
Merged
examples: fix (2020-04) #9203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Apr 29, 2020
bcardiff
approved these changes
Apr 29, 2020
bcardiff
added
kind:bug
RX14
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catched up examples for crystal-0.34.0.
Optional fixes
There are two more corrections due to the limitations of my tools. These are not required fixes, so I will remove them if it's not appropriate.
src/json/to_json.cr: The
Timestampclass has been defined three times. I changed the duplicated names toTimestampArrayandTimestampHashbecause defining the same class name would break my testing.src/levenshtein.cr: Since my comment based testing needs to be completed on a row-by-row basis, I put the execution result of the block in a temporary variable.
Best regards,