Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Path arguments to more methods #9153

Conversation

straight-shoota
Copy link
Member

Closes #7688

@straight-shoota straight-shoota force-pushed the feature/path-adapt-arguments branch 2 times, most recently from 295caf1 to 4e23251 Compare April 22, 2020 00:19
jhass
jhass previously approved these changes Apr 22, 2020
spec/std/dir_spec.cr Outdated Show resolved Hide resolved
@Sija
Copy link
Contributor

Sija commented Apr 22, 2020

How about Dir.current returning Path?

@straight-shoota
Copy link
Member Author

@Sija Yeah that should be the goal. But it's also a breaking change. I want to ship the non-breaking changes to prepare the API first.
There are also a lot of other methods on Dir and File that should return Path, not just Dir.current.

RX14
RX14 previously approved these changes Apr 24, 2020
@straight-shoota
Copy link
Member Author

Rebased on master and squashed. Needs an approval again.

@RX14
Copy link
Contributor

RX14 commented Apr 25, 2020

Can we get rid of the force push dismiss? It's really useful to know whether past reviews were 👍 or 👎 before the force push, and this setting completely destroys that info.

@straight-shoota straight-shoota added this to the 0.35.0 milestone Apr 25, 2020
@straight-shoota straight-shoota merged commit 533cd24 into crystal-lang:master Apr 26, 2020
@straight-shoota straight-shoota deleted the feature/path-adapt-arguments branch April 26, 2020 11:51
@waj
Copy link
Member

waj commented Apr 26, 2020

Can we get rid of the force push dismiss? It's really useful to know whether past reviews were 👍 or 👎 before the force push, and this setting completely destroys that info.

@RX14 the setting says "Dismiss stale pull request approvals when new commits are pushed". So isn't just 👍 that are dismissed?

@RX14
Copy link
Contributor

RX14 commented Apr 26, 2020

It seems to do both, and everyone seems to dislike the setting in practice.

With better UX and better semantics from github, it could be a wonderful feature, but in practice, right now, it seems to do more harm than good.

@waj
Copy link
Member

waj commented Apr 26, 2020

I don’t get it. It’s just approvals that get dismissed but comments are still there.

@waj
Copy link
Member

waj commented Apr 26, 2020

Oh you mean if someone request changes you don’t see the red flag anymore after the push?

@asterite
Copy link
Member

I think he means it's annoying having to reapprove things when minor fixes are. made.

@straight-shoota
Copy link
Member Author

We should better discuss this somewhere else. Maybe on the forum.

@RX14
Copy link
Contributor

RX14 commented Apr 26, 2020

@asterite she means both what you and waj said :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined method 'split' for Path
7 participants