-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Path arguments to more methods #9153
Add support for Path arguments to more methods #9153
Conversation
295caf1
to
4e23251
Compare
How about |
@Sija Yeah that should be the goal. But it's also a breaking change. I want to ship the non-breaking changes to prepare the API first. |
18db973
to
d5e79cf
Compare
Rebased on master and squashed. Needs an approval again. |
Can we get rid of the force push dismiss? It's really useful to know whether past reviews were 👍 or 👎 before the force push, and this setting completely destroys that info. |
@RX14 the setting says "Dismiss stale pull request approvals when new commits are pushed". So isn't just 👍 that are dismissed? |
It seems to do both, and everyone seems to dislike the setting in practice. With better UX and better semantics from github, it could be a wonderful feature, but in practice, right now, it seems to do more harm than good. |
I don’t get it. It’s just approvals that get dismissed but comments are still there. |
Oh you mean if someone request changes you don’t see the red flag anymore after the push? |
I think he means it's annoying having to reapprove things when minor fixes are. made. |
We should better discuss this somewhere else. Maybe on the forum. |
@asterite she means both what you and waj said :) |
Closes #7688