Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure UNIXServer is accepting before closing in specs #8755

Merged
merged 2 commits into from
Feb 17, 2020

Conversation

bcardiff
Copy link
Member

@bcardiff bcardiff commented Feb 7, 2020

In multi-thread the .accept might not execute right after the :begin is received.

more sporadic failures in preview_mt fixed.

@RX14
Copy link
Contributor

RX14 commented Feb 7, 2020

Shall we introduce a wait_until_blocked(Fiber) and a wait_until_finished(Fiber) spec helpers?

@bcardiff bcardiff force-pushed the fix/unix-server-specs-mt branch from ef605c4 to 5e29da1 Compare February 10, 2020 18:49
@bcardiff
Copy link
Member Author

Rebased and helpers added

@bcardiff bcardiff requested a review from RX14 February 10, 2020 19:35
Copy link
Contributor

@RX14 RX14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful

@bcardiff bcardiff added this to the 0.34.0 milestone Feb 17, 2020
@bcardiff bcardiff force-pushed the fix/unix-server-specs-mt branch from 5e29da1 to f491098 Compare February 17, 2020 18:14
@bcardiff
Copy link
Member Author

Rebased on master to solve merge conflicts.

@bcardiff bcardiff merged commit 2a2f069 into crystal-lang:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants