Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Process::Status#exit_status #8647

Merged
merged 7 commits into from
Dec 25, 2024
Merged

Deprecate Process::Status#exit_status #8647

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b4c7e79
Deprecating the Process exit_status method in favor of exit_code. Fix…
jwoertink Jan 3, 2020
e0af96d
Ran formatter to catch some whitespace
jwoertink Jan 3, 2020
24f54eb
Merge master. Resolved conflict
jwoertink Sep 21, 2024
8c52878
moving the deprecation to the new method added
jwoertink Sep 21, 2024
e45fe09
Don't fallback to the now deprecated method call when calling exit_code.
jwoertink Sep 23, 2024
0533816
Merge branch 'master' into issues/8381
straight-shoota Dec 23, 2024
d5b1c78
Mention more alternatives
straight-shoota Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/process/status.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ end
class Process::Status
# Platform-specific exit status code, which usually contains either the exit code or a termination signal.
# The other `Process::Status` methods extract the values from `exit_status`.
@[Deprecated("Use `#exit_reason`, `#exit_code`, or `#system_exit_status` instead")]
def exit_status : Int32
@exit_status.to_i32!
end
Expand Down Expand Up @@ -268,7 +269,7 @@ class Process::Status
# define __WEXITSTATUS(status) (((status) & 0xff00) >> 8)
(@exit_status & 0xff00) >> 8
{% else %}
exit_status
@exit_status.to_i32!
{% end %}
end

Expand Down
Loading