Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mutex specs race condition on mt #8643

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Fix mutex specs race condition on mt #8643

merged 1 commit into from
Jan 3, 2020

Conversation

bcardiff
Copy link
Member

@bcardiff bcardiff commented Jan 2, 2020

In https://circleci.com/gh/crystal-lang/crystal/36001 I experienced a race condition introduced in #8563 .

After this changes the loop will not only wait for the mutex to be assigned but for the lock to occur.

@bcardiff bcardiff added this to the 0.33.0 milestone Jan 2, 2020
@RX14
Copy link
Member

RX14 commented Jan 2, 2020

nice catch, weird ci didnt properly trigger here though...

@bcardiff bcardiff merged commit 15bfc23 into crystal-lang:master Jan 3, 2020
@bcardiff bcardiff deleted the fix/mutex-spec branch January 3, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:specs topic:stdlib:concurrency
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bcardiff @RX14