Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regular failing spec with preview_mt #8592

Merged
merged 3 commits into from
Dec 17, 2019
Merged

Fix regular failing spec with preview_mt #8592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f608ef9
CI: Turn off verbose output in preview_mt specs
bcardiff Nov 22, 2019
d7eebfb
Wait for server to listen on HTTP::Server close spec
bcardiff Nov 22, 2019
f6a1c33
Reduce sleep time
bcardiff Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
- run: echo 'export CURRENT_TAG="$CIRCLE_TAG"' >> $BASH_ENV
- run: bin/ci prepare_build
- run: bin/ci with_build_env 'make crystal'
- run: bin/ci with_build_env 'CRYSTAL_WORKERS=4 make std_spec threads=1 verbose=1 FLAGS="-D preview_mt"'
- run: bin/ci with_build_env 'CRYSTAL_WORKERS=4 make std_spec threads=1 FLAGS="-D preview_mt"'

check_format:
machine: true
Expand Down
10 changes: 10 additions & 0 deletions spec/std/http/server/server_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,21 @@ describe HTTP::Server do
ch.send :end
end

# wait for the server to start listening, and a little longer
# so the spawn that performs the accept has chance to run
while !server.listening?
Fiber.yield
end
sleep 0.1

delay(1) { ch.send :timeout }

TCPSocket.open(address.address, address.port) { }

# wait before closing the server
sleep 0.1
server.close

ch.receive.should eq(:end)
end

Expand Down