Fixes issue with aarch64 invalid memory access #7983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change properly maps the 64bit Intrinsic alloc method for aarch64 architecture. This fixes issue crystal-lang#7299
|
Thank you! I think we have a bits64 flag. It's checked in other parts of the code. |
|
Maybe also fixes #7983 |
asterite
reviewed
Jul 23, 2019
use `bits64` instead Co-Authored-By: Ary Borenszweig <asterite@gmail.com>
asterite
approved these changes
Jul 23, 2019
|
Thank you 🙇 |
bcardiff
added
kind:bug
dnamsons
pushed a commit
to dnamsons/crystal
that referenced
this pull request
Jan 10, 2020
Properly maps the 64bit Intrinsic alloc method for aarch64 architecture. Co-Authored-By: Ary Borenszweig <asterite@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change properly maps the 64bit Intrinsics memory methods for
aarch64architecture.This fixes issue #7293 and possibly #7299