Code

Prevent Time::Span overflow#5306

Code

Closed

petoem wants to merge 13 commits intocrystal-lang:mastercrystal-lang/crystal:masterfrom petoem:fix-time_spanpetoem/crystal:fix-time_spanCopy head branch name to clipboard

+39-14

Commits

Commits on Nov 15, 2017

• Fix Time::Span multiply and divide with numbers

  petoem

  committed
  c284ff4

  Copy full SHA for c284ff4

• Improve Time::Span documentation

  petoem

  committed
  f66c62a

  Copy full SHA for f66c62a

Commits on Nov 16, 2017

• Check for overflow in Time::Span constructor

  petoem

  committed
  1e000ca

  Copy full SHA for 1e000ca

Commits on Nov 17, 2017

• Improve initialize readability

  petoem

  committed
  9ed4b1c

  Copy full SHA for 9ed4b1c

• Check overflow on Time::Span addition

  petoem

  committed
  436946f

  Copy full SHA for 436946f

Commits on Nov 19, 2017

• Improve checks in Time::Span constructor

  petoem

  committed
  a994a2d

  Copy full SHA for a994a2d

• Allow more ways to initialize Time::Span

  petoem

  committed
  d192e38

  Copy full SHA for d192e38

• Add separate multiply and divide methods for Float

  petoem

  committed
  df00820

  Copy full SHA for df00820

• Float#nanoseconds and Float#seconds use trunc and raise when not in range

  petoem

  committed
  8e2045d

  Copy full SHA for 8e2045d

• Revert "Check overflow on Time::Span addition"

  petoem

  committed
  4cb269c

  Copy full SHA for 4cb269c

Commits on Nov 26, 2017

• Remove comments

  petoem

  committed
  9c83512

  Copy full SHA for 9c83512

• Move unless/raise block to initialize

  petoem

  committed
  05865d0

  Copy full SHA for 05865d0

• Time::Span: make sure seconds is Int64

  Show description for 6ba6e49
  petoem

  committed
  6ba6e49

  Copy full SHA for 6ba6e49