Fix end locations of some Crystal AST nodes #15452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
LGTM
But it would be nice if we could split out the line continuation fix (4776fa1) into a separate PR.
It's not directly related to the other changes.
straight-shoota
added
kind:bug
FnControlOption
force-pushed
the
end_location
branch
from
4776fa1 to
673353c
Compare
straight-shoota
approved these changes
Feb 12, 2025
|
@FnControlOption Would be nice to fix as well the issue mentioned in crystal-ameba/ameba#548 (comment) |
|
Btw, CI is failing in (only) one instance with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added end locations to
Case,Asm, andSelect