Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nil return type restriction to String::Formatter#consume_substitution #14430

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Add Nil return type restriction to String::Formatter#consume_substitution #14430

merged 1 commit into from
Apr 5, 2024

Conversation

straight-shoota
Copy link
Member

This is a workaround for a compiler error that fails to type this method (#7461).

@straight-shoota
Add Nil return type restriction to `String::Formatter#consume_subst…
d582a49 
…itution`

This is a workaround for a compiler error that fails to type this
method (crystal-lang#7461).
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:text labels Apr 4, 2024
@straight-shoota straight-shoota self-assigned this Apr 4, 2024
ysbaddaden
ysbaddaden approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should let a NOTE or a FIXME to explain/reference why the explicit Nil return type is required?

@straight-shoota
Copy link
Member Author

I omitted that because the Nil restriction makes sense regardless. This method doesn't return anything.

@straight-shoota straight-shoota added this to the 1.12.0 milestone Apr 4, 2024
@straight-shoota straight-shoota merged commit 1675145 into crystal-lang:master Apr 5, 2024
58 checks passed
@straight-shoota straight-shoota deleted the fix/workaround-consumed_substitution-has-no-type branch April 5, 2024 14:04
@BrewTestBot BrewTestBot mentioned this pull request Apr 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

Assignees

@straight-shoota straight-shoota

Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:text
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @ysbaddaden