-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement File.readable?
and .writable?
in Win32
#14420
Implement File.readable?
and .writable?
in Win32
#14420
Conversation
Could anyone reproduce the interpreter failures locally? |
Nope. This seems very odd. Especially that both, readable and writable are failing. Maybe a file system issue? But it would be weird to have that only in the interpreter and not in compiled mode... |
So the FS permissions definitely seem to be correct, yet the specs are still failing:
I pushed another commit to see what happens for |
Interestingly, in the latest run there's only one failure: https://github.com/crystal-lang/crystal/actions/runs/8551832454/job/23432079701?pr=14420 |
Turns out this was just #13217 and compiled code would have had the same issue, CI didn't notice because we pass |
Doh 🤦 Yeah that makes a lot of sense. Great find! |
Note that
File.writable
returnstrue
for read-only directories, which is inconsistent withFile.info
; this has always been the case for the originalLibC._waccess_s
, this PR merely exposes this fact in Crystal code.