Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Socket#tty? to false on Windows #13175

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Fix Socket#tty? to false on Windows #13175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78f057c
Correctly use `_isatty` for sockets on windows
Blacksmoke16 Mar 10, 2023
11a8918
Error handling
Blacksmoke16 Mar 10, 2023
5c31a96
Simply return `false` for `Socket#system_tty?`
Blacksmoke16 Mar 10, 2023
69e1a95
Update spec to use non unix socket
Blacksmoke16 Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions spec/std/socket/socket_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ describe Socket, tags: "network" do
end
end

describe "#tty?" do
it "with non TTY" do
Socket.new(Socket::Family::INET, Socket::Type::STREAM, Socket::Protocol::TCP).tty?.should be_false
end
end

pending_win32 ".accept" do
client_done = Channel(Nil).new
server = Socket.new(Socket::Family::INET, Socket::Type::STREAM, Socket::Protocol::TCP)
Expand Down
2 changes: 1 addition & 1 deletion src/crystal/system/win32/socket.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ module Crystal::System::Socket
end

private def system_tty?
LibC.isatty(fd) == 1
false
end

private def unbuffered_read(slice : Bytes)
Expand Down