Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #check_needs_resize from IO::Memory, String::Builder #10732

Merged
merged 1 commit into from
May 23, 2021
Merged

Remove #check_needs_resize from IO::Memory, String::Builder #10732

merged 1 commit into from
May 23, 2021

Conversation

straight-shoota
Copy link
Member

These methods have apparently been unused since forever, even before MemoryIO became IO::Memory.
They're private, so we can just remove them without deprecation.

asterite
asterite approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@straight-shoota straight-shoota added this to the 1.1.0 milestone May 20, 2021
@straight-shoota straight-shoota changed the title Remove #check_needs_resize from IO::Memory, String::Builder Remove #check_needs_resize from IO::Memory, String::Builder May 23, 2021
@straight-shoota straight-shoota merged commit bb5e532 into crystal-lang:master May 23, 2021
@straight-shoota straight-shoota deleted the refactor/check_needs_resize branch May 23, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib:files topic:stdlib:text
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@straight-shoota @asterite @bcardiff