Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match named arguments by external parameter names when checking overload cover #10530

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Match named arguments by external parameter names when checking overload cover #10530

merged 1 commit into from
Mar 22, 2021

Conversation

HertzDevil
Copy link
Contributor

Fixes #10516.

asterite
asterite approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic labels Mar 22, 2021
@bcardiff bcardiff added this to the 1.0.0 milestone Mar 22, 2021
@bcardiff bcardiff merged commit 917d41c into crystal-lang:master Mar 22, 2021
@HertzDevil HertzDevil deleted the bug/external-name-overloads branch March 22, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Invalid memory access with external name call on T.class forall method
4 participants
@HertzDevil @asterite @straight-shoota @bcardiff