Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let IO::Memory not be writable with read-only Slice #10391

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Let IO::Memory not be writable with read-only Slice #10391

merged 1 commit into from
Feb 14, 2021

Conversation

straight-shoota
Copy link
Member

Resolves #10362

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:files labels Feb 13, 2021
bcardiff
bcardiff approved these changes Feb 13, 2021
View reviewed changes
Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I nearly forgot about this. Thanks!

@bcardiff bcardiff added this to the 1.0.0 milestone Feb 13, 2021
@asterite asterite merged commit 91fa44c into crystal-lang:master Feb 14, 2021
@straight-shoota straight-shoota deleted the fix/io-memory-writable branch February 14, 2021 13:46
@straight-shoota
Copy link
Member Author

@bcardiff I occasionally look through recently discussed bug issues. This GitHub query helps: is:issue is:open sort:updated-desc label:kind:bug -label:community:help-wanted -label:status:someday

I also have one for non-reviewed PRs: is:pr is:open sort:updated-desc -author:@me -reviewed-by:@me -label:status:needs-more-info -label:pr:needs-work -label:pr:wip .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:files
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

IO::Memory should not be writable when created from a read-only Slice
3 participants
@straight-shoota @asterite @bcardiff