Make {Enumerable,Iterator}#flat_map work with mixed element types #10329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following code fails:
There is no reason that the block must return
Array
s andIterator
s of the same element type;Array#concat
and#push
, which this method relies on, already work with element types that differ from self's.The
Iterator
form will yield the correct elements, but it uses the wrong generic type argument, breaking certain methods like#to_a
:The type restriction
Array(U) | Iterator(U) | U forall U
is used in the block's return type. This restriction is unneeded, since whether a value should be flattened or not depends on its dynamic type, not static type. This PR fixes both methods by replacing the restrictions withtypeof
expressions that deduce the common element type. Fixes #5803: