Allow to find macros using tool implementations.

[faustinoaq]

Currently crystal tool implementations works for methods and functions, but not for macros.

I know crystal tool expand but it doesn't show enough information:

macro imprime(texto)
  puts "{{texto}}"
end

imprime hola

Using tool expand with the code above:

>>> crystal tool expand -c /home/user/sample.cr:5:1 /home/user/sample.cr
1 expansion found
expansion 1:
   imprime(hola)

~> puts("hola")

It doesn't show information about location or position.

It's very useful for editor support and tooling, see: https://github.com/faustinoaq/vscode-crystal-lang/issues/4

I think would be useful to add location info to crystal tool expand or allow to find macros using crystal tool implementations.

[makenowjust]

Okay, I try to implement this. But current compiler does not keep the information wanted by you (Thus crystal tool expand and crystal tool implementations can't show this.), so I should modify the compiler a bit. Sorry, I needs some days to implement this. Please wait.

[makenowjust]

Implementing this on crystall tool implementations is very difficult because crystal tool implementations treats AST nodes after macro expansion.

[faustinoaq]

So, adding location info to tool expand is the right way.

[makenowjust]

Implement done. I'll write spec, then open a new pull request tomorrow. I am in bed now. Good night.

[faustinoaq]

@makenowjust Thanks you so much! Good Night 😄

[makenowjust]

Screen shot:

Interesting point is the line # expand the macro 'imprime' (/Users/makenowjust/Projects/labo/crystal/a.cr:1:1).

@faustinoaq This is what you want, okay?

[straight-shoota]

Wow, @makenowjust you say you need some days to implement and an hour later you're done? Crazy guy 🥇
But what's wrong with your colors? There is so little contrast in your screenshot...

[makenowjust]

@straight-shoota I like little contrast color, but I should have taken care it when show to others. Sorry 🙇

[faustinoaq]

Yeah, your solution solve this issue. <3 <3 <3 A basic macro location is enough. Does it show in json output too?

…

On Tue, Aug 1, 2017 at 5:21 AM, TSUYUSATO Kitsune ***@***.***> wrote: Screen shot: [image: 2017-08-01 19 18 04] <https://user-images.githubusercontent.com/6679325/28820868-300a03a6-76ee-11e7-9542-63168c6d4830.png> Interesting point is the line # expand the macro 'imprime' (/Users/makenowjust/Projects/labo/crystal/a.cr:1:1). @faustinoaq <https://github.com/faustinoaq> This is what you want, okay? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4766 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC7Nx9HtaGa2r8i9j6ERdhY_e5YcYg-aks5sTvwigaJpZM4OoZSN> .

[makenowjust]

@faustinoaq Of course, yes. And this JSON structure is same as crystal tool implementations output, so I think it is easy to fix editor extension for this.