Call factor_powers_of_ten within BigDecimal#ceil

crystal-lang · Feb 12, 2020 · 5596c23 · 5596c23
1 parent a2bba01
commit 5596c23
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/spec/std/big/big_decimal_spec.cr b/spec/std/big/big_decimal_spec.cr
@@ -337,36 +337,43 @@ describe BigDecimal do
     bd2 = BigDecimal.new(-123, 5)
     bd3 = BigDecimal.new(123, 0)
     bd4 = BigDecimal.new(-123, 0)
+    bd5 = "-123.000".to_big_d
 
     bd1.to_i.should eq 0
     bd2.to_i.should eq 0
     bd3.to_i.should eq 123
     bd4.to_i.should eq -123
+    bd5.to_i.should eq -123
 
     bd1.to_u.should eq 0
     bd2.to_u.should eq 0
     bd3.to_u.should eq 123
     bd4.to_u.should eq 123
+    bd5.to_u.should eq 123
 
     bd1.to_f.should eq 0.00123
     bd2.to_f.should eq -0.00123
     bd3.to_f.should eq 123.0
     bd4.to_f.should eq -123.0
+    bd5.to_f.should eq -123.0
 
     bd1.to_i!.should eq 0
     bd2.to_i!.should eq 0
     bd3.to_i!.should eq 123
     bd4.to_i!.should eq -123
+    bd5.to_i!.should eq -123
 
     bd1.to_u!.should eq 0
     bd2.to_u!.should eq 0
     bd3.to_u!.should eq 123
     bd4.to_u!.should eq 123
+    bd5.to_u!.should eq 123
 
     bd1.to_f!.should eq 0.00123
     bd2.to_f!.should eq -0.00123
     bd3.to_f!.should eq 123.0
     bd4.to_f!.should eq -123.0
+    bd5.to_f!.should eq -123.0
   end
 
   it "hashes" do

diff --git a/src/big/big_decimal.cr b/src/big/big_decimal.cr
@@ -289,6 +289,8 @@ struct BigDecimal < Number
   end
 
   def ceil : BigDecimal
+    factor_powers_of_ten
+
     mask = power_ten_to(@scale)
     diff = (mask - @value % mask) % mask
     (self + BigDecimal.new(diff, @scale))
@@ -331,11 +333,7 @@ struct BigDecimal < Number
 
   # Converts to `BigInt`. Truncates anything on the right side of the decimal point.
   def to_big_i
-    if self >= 0
-      self.floor.value
-    else
-      self.ceil.value
-    end
+    (self >= 0 ? floor : ceil).value
   end
 
   # Converts to `BigFloat`.