Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bundling use items. #1030

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Avoid bundling use items. #1030

merged 3 commits into from
Oct 24, 2024

Conversation

maximebuyse
Copy link
Contributor

@maximebuyse maximebuyse commented Oct 23, 2024

This avoids adding include statements in the generated f* with DUMMY idents (see #272)

@maximebuyse maximebuyse marked this pull request as draft October 23, 2024 13:13
@W95Psp
Copy link
Collaborator

W95Psp commented Oct 24, 2024

I think this makes a lot of sense.
The Use items are exposed in the AST, but that is a bit useless: use and their name indirections are erased by Rust earlier than where we hook.
Thus no any item used by Rust will ever refer to such use paths.

We should revisit use in the AST. But definitively, that's the use items in hax' AST which are to revisit, not the bundles.
I'd be fine merging this PR if you had a comment that explains a bit this situation, I think that's a useful PR. Wdyt @maximebuyse?

@maximebuyse
Copy link
Contributor Author

I think this makes a lot of sense. The Use items are exposed in the AST, but that is a bit useless: use and their name indirections are erased by Rust earlier than where we hook. Thus no any item used by Rust will ever refer to such use paths.

We should revisit use in the AST. But definitively, that's the use items in hax' AST which are to revisit, not the bundles. I'd be fine merging this PR if you had a comment that explains a bit this situation, I think that's a useful PR. Wdyt @maximebuyse?

Yes, I think it will become irrelevant if we try to minimize the bundles (use items shouldn't have or be dependencies) but it is a good way to get rid of this problem for now. I'll add a comment.

@maximebuyse maximebuyse self-assigned this Oct 24, 2024
@maximebuyse maximebuyse requested a review from W95Psp October 24, 2024 08:07
@maximebuyse maximebuyse marked this pull request as ready for review October 24, 2024 08:07
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit:!

@W95Psp W95Psp added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 00c7853 Oct 24, 2024
13 checks passed
@W95Psp W95Psp deleted the avoid-bundling-use-items branch October 24, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants