Avoid ByteBuffer#asReadOnlyBuffer()
#29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except for some cases where a
ReadOnlyBuffer
is used in a very limited scope, we don't want to use them in conjunction with Ciphers and Macs for the following reason:A readonly buffer doesn't allow direct access to its
byte[]
, regardless of whether its on-heap or not. However, Ciphers are more efficient whenByteBuffer#hasArray()
returns true (as can be seen e.g. inCipherSpi
) as they don't need to copy bytes from the buffers to some internalbyte[]
.To avoid allocations of
byte[]
, we will therefore use.duplicate()
instead of.asReadOnlyBuffer()
, even if we don't need write access to said buffers.