Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MasterkeyHubAccess #22

Merged
merged 7 commits into from
Aug 20, 2021
Merged

Added MasterkeyHubAccess #22

merged 7 commits into from
Aug 20, 2021

Conversation

overheadhunter
Copy link
Member

Added MasterkeyHubAccess, which allows decryption of device-specific masterkeys used in Cryptomator Hub.

This facilitates ECIES with:

  • P-384 curves
  • ANSI X9.63 KDF with SHA-256 deriving a 256 + 96 bit secret
  • AES-GCM with a 256 bit KEK and 96 bit nonce* (derived by KDF)
  • No separate MAC required, as a tag is included in GCM ciphertexts

* The nonce is unique due to the nature of ECIES which facilitates ephemeral key pairs: The private key is immediately discarded during encryption, reuse is impossible when correctly implemented.

@overheadhunter
Copy link
Member Author

@SailReal Once again, can you please test this on Android 7.x? Basically copy this test over to your Android code base and see if it works. Thanks! 🙂

@overheadhunter overheadhunter added this to the 2.1.0 milestone Aug 19, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.5% 81.5% Coverage
0.0% 0.0% Duplication

Copy link
Member

@SailReal SailReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it using MasterkeyHubAccessTest as well as with GcmWithSecretNonceTest on Android 8.0 and Android 11

@overheadhunter overheadhunter merged commit 127d0fd into develop Aug 20, 2021
@overheadhunter overheadhunter deleted the feature/ecies branch August 20, 2021 10:39
@infeo
Copy link
Member

infeo commented Nov 24, 2022

For Documentation: This feature was removed again in 47a6c2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants