fix processing of \r when importing binary seedqr #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for specter-diy-docs failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #211
Until now we assumed that all messages from the host are text-based and end with
\r- QR scanner is adding\rat the end of the data, so we were using it to split data coming from the scanner when multiple QR codes are scanned one after another.This approach doesn't work when we start working with binary data. SeedQR integration is the first time we are handling QR codes in binary form.
This PR adds a possibility to tell the scanner that we are not expecting animated QR codes and ask for raw data coming from the scanner without pre-processing.