Fix crash when import watch-only wallet and click send button #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launching a fresh instance of cryptopower i get this error |
this seems to be on master as well, but this would need to be fixed in order to test this PR as i need to import a watch only wallet on a fresh install of cryptopower |
even though it's not within the scope of this PR, I'll fix it |
|
seems the issue has been resolved #202 |
|
@JustinBeBoy did you test this on a fresh install of cryptopower? cause that's how to detect the issue, it still happens |
I have tested, seem like your wallet have mixed account, I will test that case |
|
clicking the send button for the first time caused a crash |
dreacot
requested changes
Oct 25, 2023
I can't reproduce it, please explain step by step and the extended public key you use |
After a lot of test, I have found the problem |
dreacot
requested changes
Oct 26, 2023
Comment on lines
+61
to
+63
| if len(s.items) == 0 { | ||
| return D{} | ||
| } |
There was a problem hiding this comment.
i see no harm in showing the asset slider for a watch only wallet
There was a problem hiding this comment.
or is a watch only wallet's balance not calculated as part of the slider?
if it's not then ignore this
There was a problem hiding this comment.
or is a watch only wallet's balance not calculated as part of the slider?
if it's not then ignore this
Exactly, calculate total assets balance not include watch-only wallet, additional it causes crash app
dreacot
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #182
This PR fix: