Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ethermint mode with features #2

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 23, 2021

Cherry-picked the commit from PeggyJV#150

  • patch deep_space with ethermint fork
  • add a PrivateKey which switch to ethermint when ethermint feature is turn on
  • change default hd_path if ethermint feature turn on

@yihuang yihuang requested a review from tomtau September 23, 2021 06:41
orchestrator/Cargo.toml Outdated Show resolved Hide resolved
Copy link

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried building this branch locally:

error[E0599]: no function or associated item named `from_secret` found for struct `cosmos_gravity::crypto::PrivateKey` in the current scope
  --> test_runner/src/happy_path.rs:61:53
   |
61 |     let dest_cosmos_private_key = CosmosPrivateKey::from_secret(&secret);
   |                                                     ^^^^^^^^^^^ function or associated item not found in `cosmos_gravity::crypto::PrivateKey`

error[E0308]: mismatched types
   --> test_runner/src/happy_path.rs:183:17
    |
183 |                 keys_to_change.orch_key,
    |                 ^^^^^^^^^^^^^^^^^^^^^^^ expected struct `deep_space::PrivateKey`, found struct `cosmos_gravity::crypto::PrivateKey`

error[E0308]: mismatched types
   --> test_runner/src/happy_path_v2.rs:114:13
    |
114 |             keys[0].validator_key,
    |             ^^^^^^^^^^^^^^^^^^^^^ expected struct `deep_space::PrivateKey`, found struct `cosmos_gravity::crypto::PrivateKey`

error[E0599]: no function or associated item named `from_secret` found for struct `cosmos_gravity::crypto::PrivateKey` in the current scope
  --> test_runner/src/orch_keys_update.rs:66:44
   |
66 |         let cosmos_key = CosmosPrivateKey::from_secret(&secret);
   |                                            ^^^^^^^^^^^ function or associated item not found in `cosmos_gravity::crypto::PrivateKey`

error[E0599]: no function or associated item named `from_secret` found for struct `cosmos_gravity::crypto::PrivateKey` in the current scope
   --> test_runner/src/utils.rs:132:40
    |
132 |     let cosmos_key = CosmosPrivateKey::from_secret(&secret);
    |                                        ^^^^^^^^^^^ function or associated item not found in `cosmos_gravity::crypto::PrivateKey`

error: aborting due to 5 previous errors

Some errors have detailed explanations: E0308, E0599.
For more information about an error, try `rustc --explain E0308`.
error: could not compile `test_runner`

is that expected?

- patch deep_space with ethermint fork
- add a PrivateKey which switch to ethermint when ethermint feature is turn on
- change default hd_path if ethermint feature turn on

change to crypto-org-chain repo

fix test_runner build
@yihuang
Copy link
Collaborator Author

yihuang commented Sep 23, 2021

tried building this branch locally:

is that expected?

fixed now.

@yihuang yihuang requested a review from tomtau September 23, 2021 07:19
@tomtau tomtau merged commit 2e23a0c into crypto-org-chain:cronos Sep 23, 2021
@yihuang yihuang deleted the cronos branch September 23, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants