Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: incarnation cache not enabled #498

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jul 12, 2024

Closes: #XXX

Description

requires crypto-org-chain/cosmos-sdk#565


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang requested a review from mmsqe July 12, 2024 03:17
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 61.53%. Comparing base (45ac081) to head (5625144).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #498      +/-   ##
===========================================
- Coverage    61.60%   61.53%   -0.07%     
===========================================
  Files          128      128              
  Lines         9480     9495      +15     
===========================================
+ Hits          5840     5843       +3     
- Misses        3100     3111      +11     
- Partials       540      541       +1     
Files Coverage Δ
app/ante/handler_options.go 61.53% <57.14%> (-0.82%) ⬇️
app/executor.go 4.54% <0.00%> (-0.72%) ⬇️

@yihuang yihuang enabled auto-merge (squash) July 15, 2024 03:19
@mmsqe
Copy link
Collaborator

mmsqe commented Jul 15, 2024

seems get some AppHash mismatch

@yihuang yihuang merged commit 9c959a2 into crypto-org-chain:develop Jul 15, 2024
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants