Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: insufficient invalid value check in eth transaction #497

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jul 12, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang July 12, 2024 01:29
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.60%. Comparing base (e5b222f) to head (cbfcc16).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #497      +/-   ##
===========================================
+ Coverage    61.59%   61.60%   +0.01%     
===========================================
  Files          128      128              
  Lines         9477     9480       +3     
===========================================
+ Hits          5837     5840       +3     
  Misses        3100     3100              
  Partials       540      540              
Files Coverage Δ
app/ante/eth.go 77.68% <100.00%> (+0.56%) ⬆️

Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, it can't be negative because it's decoded from rlp, but ok.

@mmsqe mmsqe merged commit 45ac081 into crypto-org-chain:develop Jul 12, 2024
38 of 39 checks passed
@yihuang yihuang deleted the can_transfer branch July 13, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants