Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no MaxTx set from config for mempool #496

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jul 2, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang July 2, 2024 10:29
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.59%. Comparing base (f9cd15e) to head (cd50490).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #496      +/-   ##
===========================================
+ Coverage    61.57%   61.59%   +0.01%     
===========================================
  Files          128      128              
  Lines         9474     9477       +3     
===========================================
+ Hits          5834     5837       +3     
  Misses        3100     3100              
  Partials       540      540              
Files Coverage Δ
app/app.go 76.42% <100.00%> (+0.12%) ⬆️
server/config/config.go 35.44% <ø> (ø)

server/config/config.go Outdated Show resolved Hide resolved
Co-authored-by: yihuang <huang@crypto.com>
Signed-off-by: mmsqe <mavis@crypto.com>
@mmsqe mmsqe enabled auto-merge (squash) July 2, 2024 12:44
@mmsqe mmsqe merged commit e5b222f into crypto-org-chain:develop Jul 2, 2024
38 of 39 checks passed
@mmsqe mmsqe deleted the max_tx branch August 16, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants