Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: wrong NextBaseFee in feeHistory before param change #409

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Problem: wrong NextBaseFee in feeHistory before param change #409

merged 5 commits into from
Mar 5, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Feb 28, 2024

feemarket param is not align with height

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 28, 2024
View reviewed changes
rpc/backend/utils.go Fixed Show fixed Hide fixed
@mmsqe
Problem: wrong NextBaseFee in feeHistory before param change
bcbc138 
feemarket param is not align with height
@mmsqe mmsqe marked this pull request as ready for review February 29, 2024 03:26
@mmsqe mmsqe requested a review from yihuang February 29, 2024 03:26
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 29, 2024
View reviewed changes
rpc/websockets.go
if s.certFile == "" || s.keyFile == "" {
err = http.ListenAndServe(s.wsAddr, ws)
err = http.ListenAndServe(s.wsAddr, ws) // #nosec G114 -- http functions have no support for timeouts

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: go.lang.security.audit.net.use-tls.use-tls Warning

Found an HTTP server without TLS. Use 'http.ListenAndServeTLS' instead. See https://golang.org/pkg/net/http/#ListenAndServeTLS for more information.
@mmsqe mmsqe requested a review from yihuang March 4, 2024 02:21
@mmsqe mmsqe merged commit 5b153a4 into crypto-org-chain:develop Mar 5, 2024
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang yihuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @yihuang